fix(cli): Accept --url for dart-symbol-map #3108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `cargo_bin!` macro from assert_cmd to locate the sentry-cli binary. This reads the `CARGO_BIN_EXE_sentry-cli` environment variable set by Cargo at compile time, making tests work regardless of custom `build-dir` settings in cargo config. Previously, both `Command::cargo_bin()` and trycmd's internal binary discovery would fail when a custom build directory was configured, causing tests to either error or silently pass as "ignored". Co-Authored-By: Claude <noreply@anthropic.com>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/url-argument
branch
3 times, most recently
from
7128127 to
839222f
Compare
szokeasaurusrex
changed the base branch from
master
to
szokeasaurusrex/test-fix
The --url argument was not recognized by the dart-symbol-map command because it was missing from the derive parser schema. Added the url field to the SentryCLI struct to allow global --url usage. Also updated the legacy parser to mark --url as global for consistency with other global arguments. Fixes #3106 Co-Authored-By: Claude <noreply@anthropic.com>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/url-argument
branch
from
839222f to
028e3bb
Compare
szokeasaurusrex
changed the title
--url argument is globally available for all commands
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
tests/integration/_responses/dart_symbol_map/assemble-success.json
Outdated
Show resolved
Hide resolved
szokeasaurusrex
changed the title
--url argument is globally available for all commands
szokeasaurusrex
changed the title
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
loewenheim
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
dart-symbol-mapcommand uses the derive parser, which was missing the--urlfield. This change adds it so--urlis accepted for dart-symbol-map and removes an unused dart symbol map fixture.Issues